-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update contribution guidelines, remove redundant files #1181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check all links but we can do another cleanup sweep through the while project afterwards
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
…m/paritytech/polkadot-sdk into the-right-joyce-update-guidelines
@the-right-joyce nitpick. What about formatting these text files following some terminal friendly convention? A lot of devs open these files in Like:
All this stuff is not important if you read/write markdowns on github. But can be annoying on the terminal Some references: |
@the-right-joyce The first article says that the right choice is be between 50–75, Again this is not super relevant, and if you can't automate it using the right tool then I can give these files a pass after merge. |
…m/paritytech/polkadot-sdk into the-right-joyce-update-guidelines
@Rashmirreddy please check the documentation guideline copy and see if you'd like to leave the format as is or take the advised format from @davxy |
The idea to have properly formatted markdown is good but that should be done with clear rules and a linter such as markdownlint able to check them, not a list of text rules burried in some text somewhere. Defining a linter's rules is usually a topic that requires consensus and sounds out of the scope of this PR. Since Markdown is also used by I would suggest one pass of the standard rules of By the way, why are all the files all caps ? |
It was copied from the repos, just moved to one single folder to not have 3x the same docs |
ok, I understand this PR is more about bringing those files together so let's ignore the all CAPS for now if you want. We can address that in the linting PR. |
I created a new issue for the linting topics: |
@the-right-joyce - We can go ahead with the format you have suggested. We can make changes as we progress. |
* update contribution guidelines, remove redundant files * removing doc ref labels, updating links on contribution * add manifest formatting * update title Co-authored-by: Oliver Tale-Yazdi <[email protected]> * update links to the new repo * terminal friendly convention * update doc guideline format --------- Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
* update contribution guidelines, remove redundant files * removing doc ref labels, updating links on contribution * add manifest formatting * update title Co-authored-by: Oliver Tale-Yazdi <[email protected]> * update links to the new repo * terminal friendly convention * update doc guideline format --------- Co-authored-by: Alexander Samusev <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
No description provided.